Skip to content

Pin pgx to v5.9.1#4275

Merged
ilidemi merged 1 commit into
mainfrom
pin-pgx-5.9.1
May 6, 2026
Merged

Pin pgx to v5.9.1#4275
ilidemi merged 1 commit into
mainfrom
pin-pgx-5.9.1

Conversation

@ilidemi

@ilidemi ilidemi commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Pin github.com/jackc/pgx/v5 to v5.9.1 and exclude v5.9.2 in flow/go.mod.
  • v5.9.2 flips the max_protocol_version default to auto-upgrade to Postgres wire protocol v3.2 (jackc/pgx@2f81f1fc, PR #2526), which changes decoding of macaddr[] — elements come back as raw 6-byte strings via pgtype.Array[string].
  • Add github.com/jackc/pgx/v5 to the pinned-versions checker and Renovate allowedVersions rule so future upgrades stay capped at v5.9.1.

Created a task under Maintenance to upgrade

@ilidemi ilidemi mentioned this pull request May 5, 2026
Closed
1 task
@ilidemi ilidemi requested review from jgao54 and pfcoperez May 5, 2026 21:34
@claude

claude Bot commented May 5, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@ilidemi ilidemi enabled auto-merge (squash) May 5, 2026 21:36
@codecov

codecov Bot commented May 5, 2026

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
2192 2 2190 205
View the top 2 failed test(s) by shortest run time 
github.com/PeerDB-io/peerdb/flow/e2e::TestApiPg
Stack Traces | 0s run time 
=== RUN   TestApiPg
=== PAUSE TestApiPg
=== CONT  TestApiPg
--- FAIL: TestApiPg (0.00s)
2026/05/05 21:39:33 INFO Executing and processing query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,key,value,created_at FROM e2e_test_bq_hbsimfis_20260505213924.\"test_partition_reorder\" ORDER BY id"
2026/05/05 21:39:33 INFO Executing and processing query stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,key,value,created_at FROM e2e_test_bq_hbsimfis_20260505213924.\"test_partition_reorder\" ORDER BY id"
2026/05/05 21:39:33 INFO [pg_query_executor] declared cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursorQuery="DECLARE peerdb_cursor_8129828950310511556 CURSOR FOR SELECT id,key,value,created_at FROM e2e_test_bq_hbsimfis_20260505213924.\"test_partition_reorder\" ORDER BY id" args=[]
2026/05/05 21:39:33 INFO [pg_query_executor] fetching rows start x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,key,value,created_at FROM e2e_test_bq_hbsimfis_20260505213924.\"test_partition_reorder\" ORDER BY id" channelLen=0
2026/05/05 21:39:33 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_8129828950310511556
2026/05/05 21:39:33 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_8129828950310511556 records=3 bytes=51 channelLen=2
2026/05/05 21:39:33 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,key,value,created_at FROM e2e_test_bq_hbsimfis_20260505213924.\"test_partition_reorder\" ORDER BY id" rows=3 bytes=51 channelLen=2
2026/05/05 21:39:33 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_8129828950310511556
2026/05/05 21:39:33 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_8129828950310511556 records=0 bytes=0 channelLen=0
2026/05/05 21:39:33 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,key,value,created_at FROM e2e_test_bq_hbsimfis_20260505213924.\"test_partition_reorder\" ORDER BY id" rows=0 bytes=0 channelLen=0
2026/05/05 21:39:33 INFO [pg_query_executor] committing transaction x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart
2026/05/05 21:39:33 INFO [pg_query_executor] committed transaction for query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,key,value,created_at FROM e2e_test_bq_hbsimfis_20260505213924.\"test_partition_reorder\" ORDER BY id" rows=3 bytes=51 channelLen=0

github.com/PeerDB-io/peerdb/flow/e2e::TestApiPg/TestPostgresDestinationValidation_NumericPrecisionMismatch
Stack Traces | 0.04s run time 
=== RUN   TestApiPg/TestPostgresDestinationValidation_NumericPrecisionMismatch
=== PAUSE TestApiPg/TestPostgresDestinationValidation_NumericPrecisionMismatch
=== CONT  TestApiPg/TestPostgresDestinationValidation_NumericPrecisionMismatch
    e2eshared.go:34: 
        	Error Trace:	.../flow/e2e/clickhouse.go:415
        	            				.../flow/e2e/api_test.go:233
        	            				.../flow/e2eshared/e2eshared.go:34
        	Error:      	Received unexpected error:
        	            	failed to create catalog connection pool: unable to establish connection with catalog: FATAL: terminating connection due to administrator command (SQLSTATE 57P01)
        	Test:       	TestApiPg/TestPostgresDestinationValidation_NumericPrecisionMismatch
--- FAIL: TestApiPg/TestPostgresDestinationValidation_NumericPrecisionMismatch (0.04s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: The sole test failure (TestApiPg/TestPostgresDestinationValidation_NumericPrecisionMismatch) was caused by PostgreSQL SQLSTATE 57P01 (admin_shutdown) — a transient connection termination from a concurrent test teardown, not a code defect.
Confidence: 0.95

✅ Automatically retrying the workflow

View workflow run

pfcoperez
pfcoperez approved these changes May 6, 2026
View reviewed changes

@pfcoperez pfcoperez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved conflicts, LGTM!
Merging as CI pases.

@ilidemi ilidemi merged commit 0f65b72 into main May 6, 2026
16 checks passed
@ilidemi ilidemi deleted the pin-pgx-5.9.1 branch May 6, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pfcoperez pfcoperez pfcoperez approved these changes
@jgao54 jgao54 Awaiting requested review from jgao54

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ilidemi @pfcoperez